fix(f3): fix hot loop in F3 participation #12575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
fix/f3-participate-hotloop
branch
2 times, most recently
from
1a4840e
to
bc62fd8
Compare
Stebalien
reviewed
Oct 10, 2024
Kubuxu
removed
the
skip/changelog
Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
fix/f3-participate-hotloop
branch
from
cd159b2
to
4a25048
Compare
masih
approved these changes
Oct 10, 2024
Stebalien
approved these changes
Oct 10, 2024
Stebalien
force-pushed
the
fix/f3-participate-hotloop
branch
from
f331120
to
51c60e1
Compare
44 tasks
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
* fix(f3): fix hot loop in F3 participation * fix(f3): Correct lease expiration log message * feat(f3): log not-before and not-after for new leases * test(f3): make the f3-enabled test wait for at one lease to expire --------- Signed-off-by: Jakub Sztandera <[email protected]> Co-authored-by: Steven Allen <[email protected]>
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
* fix(f3): fix hot loop in F3 participation * fix(f3): Correct lease expiration log message * feat(f3): log not-before and not-after for new leases * test(f3): make the f3-enabled test wait for at one lease to expire --------- Signed-off-by: Jakub Sztandera <[email protected]> Co-authored-by: Steven Allen <[email protected]>
rjan90
pushed a commit
that referenced
this pull request
Oct 14, 2024
* fix(f3): fix hot loop in F3 participation * fix(f3): Correct lease expiration log message * feat(f3): log not-before and not-after for new leases * test(f3): make the f3-enabled test wait for at one lease to expire --------- Signed-off-by: Jakub Sztandera <[email protected]> Co-authored-by: Steven Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the
awaitLeaseExpiry, we would retry immediately, which then would cause a hot loop.Fix the bug and add a bit of hot-loop protection.